Remove TermsDomainDb::getReadConnection param

This was never needed for the terms db access.

Bug: T351802
Change-Id: Iaad4de4029943d03414a3b9373f0a1cc062b9d08

lib/includes/Rdbms/RepoDomainTermsDb.php

@@ -28,8 +28,8 @@ public function getAutoCommitPrimaryConnection(): IDatabase {
 		return $this->repoDb->getAutoCommitPrimaryConnection();
 	}
 
-	public function getReadConnection( ?array $groups = null ): IReadableDatabase {
-		return $this->repoDb->connections()->getReadConnection( $groups );
+	public function getReadConnection(): IReadableDatabase {
+		return $this->repoDb->connections()->getReadConnection();
 	}
 
 	public function waitForReplicationOfAllAffectedClusters( ?int $timeout = null ): void {

lib/includes/Rdbms/TermsDomainDb.php

@@ -21,7 +21,7 @@ public function getWriteConnection(): IDatabase;
 
 	public function getAutoCommitPrimaryConnection(): IDatabase;
 
-	public function getReadConnection( ?array $groups = null ): IReadableDatabase;
+	public function getReadConnection(): IReadableDatabase;
 
 	public function waitForReplicationOfAllAffectedClusters( ?int $timeout = null ): void;
 

lib/tests/phpunit/Rdbms/RepoDomainTermsDbTest.php

@@ -20,21 +20,19 @@
 class RepoDomainTermsDbTest extends \PHPUnit\Framework\TestCase {
 
 	public function testGetReadConnection(): void {
-		$loadGroups = [ 'some group' ];
 		$expected = $this->createStub( IDatabase::class );
 
 		$connectionManager = $this->createMock( ConnectionManager::class );
 		$connectionManager->expects( $this->once() )
 			->method( 'getReadConnection' )
-			->with( $loadGroups )
 			->willReturn( $expected );
 
 		$repoDomainDb = $this->createStub( RepoDomainDb::class );
 		$repoDomainDb->method( 'connections' )->willReturn( $connectionManager );
 
 		$this->assertSame(
 			$expected,
-			( new RepoDomainTermsDb( $repoDomainDb ) )->getReadConnection( $loadGroups )
+			( new RepoDomainTermsDb( $repoDomainDb ) )->getReadConnection()
 		);
 	}