Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused files - WPB-8605 #2221

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
+1 −284
Draft

chore: remove unused files - WPB-8605 #2221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b2503ef
chore: remove unused files
netbe Nov 28, 2024
3e98481
remove import
netbe Dec 5, 2024
1239f1e
Merge branch 'develop' into feat/remove-dead-code-WPB-8605
netbe Dec 9, 2024
a8c56d2
remove ZMAddressBookContact
netbe Dec 10, 2024
c6dd866
Merge branch 'develop' into feat/remove-dead-code-WPB-8605
netbe Dec 12, 2024
ab2f9ab
Merge branch 'feat/remove-dead-code-WPB-8605' of github.com:wireapp/w…
netbe Dec 12, 2024
27a50e6
draft
netbe Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions wire-ios-sync-engine/Source/E2EE/ZMAPSMessageDecoder.h
View file
Open in desktop

This file was deleted.

101 changes: 0 additions & 101 deletions wire-ios-sync-engine/Source/E2EE/ZMAPSMessageDecoder.m
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion wire-ios-sync-engine/Source/Public/WireSyncEngine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
// PRIVATE
#import <WireSyncEngine/ZMBlacklistVerificator.h>
#import <WireSyncEngine/ZMAuthenticationStatus.h>
#import <WireSyncEngine/ZMAPSMessageDecoder.h>
#import <WireSyncEngine/NSError+ZMUserSessionInternal.h>
#import <WireSyncEngine/ZMOperationLoop.h>
#import <WireSyncEngine/ZMOperationLoop+Private.h>
Expand Down
1 change: 1 addition & 0 deletions wire-ios-sync-engine/Source/Synchronization/Strategies/UserClientRequestStrategy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ public final class UserClientRequestStrategy: ZMObjectSyncStrategy, ZMObjectStra

if keys.contains(ZMUserClientNeedsToUpdateSignalingKeysKey) {
do {
// what are these: signaling keys? what is it for?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@typfel I am trying to remove some files (ZMAPSMessageDecoder) you mention a while ago, is APSSignalingKeysStore still useful?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APS signalling keys were used in the past to encrypt/decrypt the content of push notification back in the day when messages weren't end-2-end encrypted.

return try requestsFactory.updateClientSignalingKeysRequest(
userClient,
apiVersion: apiVersion
Expand Down
8 changes: 0 additions & 8 deletions wire-ios-sync-engine/WireSyncEngine.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,6 @@
09914E531BD6613D00C10BF8 /* ZMDecodedAPSMessageTest.m in Sources */ = {isa = PBXBuildFile; fileRef = 09914E521BD6613D00C10BF8 /* ZMDecodedAPSMessageTest.m */; };
09B730961B3045E400A5CCC9 /* ProxiedRequestStatusTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 09B730941B3045E400A5CCC9 /* ProxiedRequestStatusTests.swift */; };
09BA924C1BD55FA5000DC962 /* UserClientRequestStrategyTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0920833C1BA84F3100F82B29 /* UserClientRequestStrategyTests.swift */; };
09BCDB8E1BCE7F000020DCC7 /* ZMAPSMessageDecoder.h in Headers */ = {isa = PBXBuildFile; fileRef = 09BCDB8C1BCE7F000020DCC7 /* ZMAPSMessageDecoder.h */; settings = {ATTRIBUTES = (Public, ); }; };
09BCDB8F1BCE7F000020DCC7 /* ZMAPSMessageDecoder.m in Sources */ = {isa = PBXBuildFile; fileRef = 09BCDB8D1BCE7F000020DCC7 /* ZMAPSMessageDecoder.m */; };
09C77C531BA6C77000E2163F /* UserClientRequestStrategy.swift in Sources */ = {isa = PBXBuildFile; fileRef = 09C77C521BA6C77000E2163F /* UserClientRequestStrategy.swift */; };
160195611E30C9CF00ACBFAC /* LocalNotificationDispatcherCallingTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 160195601E30C9CF00ACBFAC /* LocalNotificationDispatcherCallingTests.swift */; };
1602B4611F3B04150061C135 /* ZMBlacklistVerificator.h in Headers */ = {isa = PBXBuildFile; fileRef = F9FD798B19EE9B9A00D70FCD /* ZMBlacklistVerificator.h */; settings = {ATTRIBUTES = (Public, ); }; };
Expand Down Expand Up @@ -716,8 +714,6 @@
0994E1F01B835C4900A51721 /* WireSyncEngine.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = WireSyncEngine.xcconfig; sourceTree = "<group>"; };
0994E1F11B835D1100A51721 /* version.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = version.xcconfig; sourceTree = "<group>"; };
09B730941B3045E400A5CCC9 /* ProxiedRequestStatusTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ProxiedRequestStatusTests.swift; sourceTree = "<group>"; };
09BCDB8C1BCE7F000020DCC7 /* ZMAPSMessageDecoder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ZMAPSMessageDecoder.h; sourceTree = "<group>"; };
09BCDB8D1BCE7F000020DCC7 /* ZMAPSMessageDecoder.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ZMAPSMessageDecoder.m; sourceTree = "<group>"; };
09C77C521BA6C77000E2163F /* UserClientRequestStrategy.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = UserClientRequestStrategy.swift; sourceTree = "<group>"; };
160195601E30C9CF00ACBFAC /* LocalNotificationDispatcherCallingTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = LocalNotificationDispatcherCallingTests.swift; sourceTree = "<group>"; };
16030DC821B01B7500F8032E /* Conversation+ReadReceiptMode.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Conversation+ReadReceiptMode.swift"; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1489,8 +1485,6 @@
isa = PBXGroup;
children = (
871667F91BB2AE9C009C6EEA /* APSSignalingKeysStore.swift */,
09BCDB8C1BCE7F000020DCC7 /* ZMAPSMessageDecoder.h */,
09BCDB8D1BCE7F000020DCC7 /* ZMAPSMessageDecoder.m */,
);
path = E2EE;
sourceTree = "<group>";
Expand Down Expand Up @@ -2730,7 +2724,6 @@
EE0CAEB12AAF306000BD2DB7 /* ZMBlacklistDownloader.h in Headers */,
544BA1271A433DE400D3B852 /* NSError+ZMUserSession.h in Headers */,
16ED865B23E2EE3C00CB1766 /* ZMMissingUpdateEventsTranscoder.h in Headers */,
09BCDB8E1BCE7F000020DCC7 /* ZMAPSMessageDecoder.h in Headers */,
540818A61BCA647D00257CA7 /* ZMBlacklistVerificator+Testing.h in Headers */,
54A3F24F1C08523500FE3A6B /* ZMOperationLoop.h in Headers */,
54FEAAA91BC7BB9C002DE521 /* ZMBlacklistDownloader+Testing.h in Headers */,
Expand Down Expand Up @@ -3366,7 +3359,6 @@
E9816C942CC925C400D77F22 /* AnalyticsEventTrackerProvider.swift in Sources */,
F148F6671FB9AA7600BD6909 /* UnregisteredTeam.swift in Sources */,
1672A64523473EA100380537 /* LabelDownstreamRequestStrategy.swift in Sources */,
09BCDB8F1BCE7F000020DCC7 /* ZMAPSMessageDecoder.m in Sources */,
E623B6382BD688D400F91B37 /* Caches.swift in Sources */,
E6BB79542C36B36E003B821B /* NetworkState.swift in Sources */,
546392721D79D5210094EC66 /* Application.swift in Sources */,
Expand Down
35 changes: 0 additions & 35 deletions wire-ios-testing/Source/Public/NSData+WireTesting.h
View file
Open in desktop

This file was deleted.

103 changes: 0 additions & 103 deletions wire-ios-testing/Source/Public/NSData+WireTesting.m
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion wire-ios-testing/Source/Public/WireTesting.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ FOUNDATION_EXPORT const unsigned char WireTestingVersionString[];
#import <WireTesting/XCTestCase+Helpers.h>
#import <WireTesting/ZMTFailureRecorder.h>
#import <WireTesting/ZMTAsserts.h>
#import <WireTesting/NSData+WireTesting.h>
#import <WireTesting/NSOperationQueue+WireTesting.h>
#import <WireTesting/ZMTImageComparator.h>
#import <WireTesting/NSUUID+WireTesting.h>
Expand Down
8 changes: 0 additions & 8 deletions wire-ios-testing/WireTesting.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
09A217F51B78DFAF0076547A /* ZMTExpectation.m in Sources */ = {isa = PBXBuildFile; fileRef = 09A217E51B78DFAF0076547A /* ZMTExpectation.m */; };
09A217F61B78DFAF0076547A /* ZMTImageComparator.h in Headers */ = {isa = PBXBuildFile; fileRef = 09A217E71B78DFAF0076547A /* ZMTImageComparator.h */; settings = {ATTRIBUTES = (Public, ); }; };
09A217F71B78DFAF0076547A /* ZMTImageComparator.m in Sources */ = {isa = PBXBuildFile; fileRef = 09A217E81B78DFAF0076547A /* ZMTImageComparator.m */; };
09A217F81B78DFAF0076547A /* NSData+WireTesting.h in Headers */ = {isa = PBXBuildFile; fileRef = 09A217E91B78DFAF0076547A /* NSData+WireTesting.h */; settings = {ATTRIBUTES = (Public, ); }; };
09A217F91B78DFAF0076547A /* NSData+WireTesting.m in Sources */ = {isa = PBXBuildFile; fileRef = 09A217EA1B78DFAF0076547A /* NSData+WireTesting.m */; };
09A217FA1B78DFAF0076547A /* NSOperationQueue+WireTesting.h in Headers */ = {isa = PBXBuildFile; fileRef = 09A217EB1B78DFAF0076547A /* NSOperationQueue+WireTesting.h */; settings = {ATTRIBUTES = (Public, ); }; };
09A217FB1B78DFAF0076547A /* NSOperationQueue+WireTesting.m in Sources */ = {isa = PBXBuildFile; fileRef = 09A217EC1B78DFAF0076547A /* NSOperationQueue+WireTesting.m */; };
09A217FC1B78DFAF0076547A /* ZMTAsserts.h in Headers */ = {isa = PBXBuildFile; fileRef = 09A217ED1B78DFAF0076547A /* ZMTAsserts.h */; settings = {ATTRIBUTES = (Public, ); }; };
Expand Down Expand Up @@ -82,8 +80,6 @@
09A217E51B78DFAF0076547A /* ZMTExpectation.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ZMTExpectation.m; sourceTree = "<group>"; };
09A217E71B78DFAF0076547A /* ZMTImageComparator.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ZMTImageComparator.h; sourceTree = "<group>"; };
09A217E81B78DFAF0076547A /* ZMTImageComparator.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ZMTImageComparator.m; sourceTree = "<group>"; };
09A217E91B78DFAF0076547A /* NSData+WireTesting.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSData+WireTesting.h"; sourceTree = "<group>"; };
09A217EA1B78DFAF0076547A /* NSData+WireTesting.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSData+WireTesting.m"; sourceTree = "<group>"; };
09A217EB1B78DFAF0076547A /* NSOperationQueue+WireTesting.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "NSOperationQueue+WireTesting.h"; sourceTree = "<group>"; };
09A217EC1B78DFAF0076547A /* NSOperationQueue+WireTesting.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "NSOperationQueue+WireTesting.m"; sourceTree = "<group>"; };
09A217ED1B78DFAF0076547A /* ZMTAsserts.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ZMTAsserts.h; sourceTree = "<group>"; };
Expand Down Expand Up @@ -260,8 +256,6 @@
09A217F01B78DFAF0076547A /* WireTesting.h */,
09A217E71B78DFAF0076547A /* ZMTImageComparator.h */,
09A217E81B78DFAF0076547A /* ZMTImageComparator.m */,
09A217E91B78DFAF0076547A /* NSData+WireTesting.h */,
09A217EA1B78DFAF0076547A /* NSData+WireTesting.m */,
09A217EB1B78DFAF0076547A /* NSOperationQueue+WireTesting.h */,
09A217EC1B78DFAF0076547A /* NSOperationQueue+WireTesting.m */,
09A217ED1B78DFAF0076547A /* ZMTAsserts.h */,
Expand Down Expand Up @@ -337,7 +331,6 @@
CEF709D91C1599E700AF3718 /* ZMMockEntity.h in Headers */,
09A217FA1B78DFAF0076547A /* NSOperationQueue+WireTesting.h in Headers */,
09A218001B78DFAF0076547A /* ZMTFailureRecorder.h in Headers */,
09A217F81B78DFAF0076547A /* NSData+WireTesting.h in Headers */,
CEF709DA1C1599ED00AF3718 /* ZMMockEntity2.h in Headers */,
09A217F41B78DFAF0076547A /* ZMTExpectation.h in Headers */,
09A217FF1B78DFAF0076547A /* WireTesting.h in Headers */,
Expand Down Expand Up @@ -472,7 +465,6 @@
CEB8FD6A1C11E50700ED0BE5 /* ZMMockManagedObjectContextFactory.m in Sources */,
09A218011B78DFAF0076547A /* ZMTFailureRecorder.m in Sources */,
16AAA62C2C22E5BD00080A06 /* FileManger+RandomCacheURL.swift in Sources */,
09A217F91B78DFAF0076547A /* NSData+WireTesting.m in Sources */,
CE6B7B301C11ED5F00FC4C2E /* ZMMockEntity.m in Sources */,
595D4B202C0A1A0500AF6269 /* XCTestExpectation+inverted.swift in Sources */,
F97E28BE1D8AACEA00A77567 /* UUID+WireTesting.swift in Sources */,
Expand Down
Loading