chore: Adding QA automation to iOS repo - WPB-15067 #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araneforseti
requested review from
netbe,
mythsunwind,
a team,
El-Fitz and
jullianm
and removed request for
a team
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 039d27c. ♻️ This comment has been updated with latest results. |
araneforseti
force-pushed
the
chore/move-qa-automation-WPB-15067
branch
from
399ac3c to
a5d2ddf
Compare
netbe
reviewed
Jan 6, 2025
wire-ios-automation/ios/src/main/java/com/wearezeta/auto/ios/common/IOSDriverBuilder.java
Outdated
Show resolved
Hide resolved
| final JSONObject processArguments = new JSONObject(); | ||
| processArguments.put("args", processArgs); | ||
| // Enable logging for AVS and calling modules by default | ||
| processArguments.put("env", ImmutableMap.of("ZMLOG_TAGS", "AVS,calling")); |
There was a problem hiding this comment.
we should remove this also on our side, ZMLOG is going away, the AVS one has been ported to WireLogger.
"calling" still exists but should soon be ported too
mythsunwind
requested changes
Jan 7, 2025
wire-ios-automation/ios/.project
Outdated
There was a problem hiding this comment.
.project files are not needed and should be ignored in gitignore
There was a problem hiding this comment.
Please delete this file. It is a config file for Netbeans. Somebody who used netbeans checked it in accidentially. Maybe add to gitignore too
There was a problem hiding this comment.
Afaik not used since years. A lot of stuff in the tools folder can be removed.
wire-ios-automation/tools/timeout
Outdated
araneforseti
force-pushed
the
chore/move-qa-automation-WPB-15067
branch
from
39253ff to
f2824af
Compare
araneforseti
force-pushed
the
chore/move-qa-automation-WPB-15067
branch
from
f2824af to
97010b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
To have the tests live with the code they are testing, we are moving the iOS automation tests out of the central QA repo and into the iOS repo
Testing
Automation running with this branch is viewable in the New Smoke job on Jenkins.
It should also be runable locally after going through all the setup
Checklist
[WPB-XXX].UI accessibility checklist
No UI changes