Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restore backup from Settings - WPB-11718 #2358

Open
wants to merge 17 commits into
base: feat/new-backup-export-UI-WPB-15211
Choose a base branch
from

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Jan 7, 2025

TaskWPB-11718 [iOS] Move backup import from login flow to settings

Issue

This PR introduces the functionality to restore a backup from settings. All logic is in the WireUI.

This includes:

  • removing backup restore from the login flow
  • refactoring SessionManager methods for backup restore
  • providing UI and error handling
  • snapshot tests

Testing

Settings -> Account -> Backup or Restore -> Restore from backup

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Test Results

    2 files     11 suites   2m 4s ⏱️
1 866 tests 1 838 ✅ 27 💤 1 ❌
1 877 runs  1 849 ✅ 27 💤 1 ❌

For more details on these failures, see this check.

Results for commit e09f5af.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 7, 2025

Datadog Report

Branch report: feat/restore-backup-WPB-11718
Commit report: f689bde
Test service: wire-ios-mono

✅ 0 Failed, 1758 Passed, 27 Skipped, 1m 56.62s Total Time

@KaterinaWire KaterinaWire marked this pull request as ready for review January 8, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant