Fix/vue3/build #1875
Merged
Fix/vue3/build #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tommytrg
force-pushed
the
fix/vue3/build
branch
3 times, most recently
from
025982f to
84a0c1a
Compare
gabaldon
reviewed
Feb 14, 2024
Tommytrg
force-pushed
the
fix/vue3/build
branch
5 times, most recently
from
faeb6ba to
87d36b8
Compare
The `ready` attribute from [rpc-websockets client](https://github.com/elpheria/rpc-websockets/blob/trunk/src/lib/client.ts#L45) is private and can't be read. We need to fix this to be able to run the build command without typescript errors.
Tommytrg
force-pushed
the
fix/vue3/build
branch
2 times, most recently
from
b1126cc to
b0c5389
Compare
We have to update the type of the input variable to avoid errors during the build process
We have to include the dependencies as devDependencies to be inclued in the build https://github.com/electron-vite/vite-plugin-electron-renderer?tab=readme-ov-file#dependencies-vs-devdependencies
Tommytrg
force-pushed
the
fix/vue3/build
branch
from
b0c5389 to
e728635
Compare
Tommytrg
force-pushed
the
fix/vue3/build
branch
from
64cd566 to
a6b58a9
Compare
gabaldon
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readyattribute from rpc-websockets clientis private and can't be read. We need to fix this to be able to run the build command without typescript errors.
the build process
close #1874