Json rpc/non sensitive stakes ranks utxos #2570
Open
+107
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a given capability
As input param `pkh` is mandatory.
guidiaz
force-pushed
the
json_rpc/non-sensitive-stakes-ranks-utxos
branch
from
c931032 to
c2cb559
Compare
|
Could you rename the commit 15d0e82 to be less than 72 chars to avoid truncation? I propose something like "feat(json_rpc): fetch ranked stake entries by capability"
|
|
Regarding the JSONRPC method "getUtxoInfo", I don't see why it is a sensitive as it requires a pkh. The sensitive layer lies in the CLI where uses the node's pkh as the default value. |
|
Feel free to request a review when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.