Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 불필요한 actuator port 설정 제거 #784

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore: 불필요한 actuator port 설정 제거 #784

merged 1 commit into from
Jan 6, 2025

Conversation

J-I-H-O
Copy link
Contributor

@J-I-H-O J-I-H-O commented Jan 5, 2025

개발 사항

  • 불필요한 actuator port 설정 제거

전달 사항

  • 현재 실행 스크립트 내부에서 actuator port 정보를 직접 주입함
  • 이때 중복된 설정이 application-prod.yml 에 존재하고, 위 값으로 덮어씌워지고 있음
  • 헷갈리니까 한 쪽에서만 합시다

@J-I-H-O J-I-H-O self-assigned this Jan 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

Test Results

230 tests   230 ✅  39s ⏱️
 47 suites    0 💤
 47 files      0 ❌

Results for commit 1196a8b.

jimi567
jimi567 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@jimi567 jimi567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나이스요 지호형님.
건드리는김에 graceful shut down 설정도 하면 어떨까요?

@J-I-H-O
Copy link
Contributor Author

J-I-H-O commented Jan 6, 2025

좀 더 알아보고 오겠슴덩 👍

@J-I-H-O J-I-H-O merged commit 3bd26c8 into develop Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehtjsv2 ehtjsv2 ehtjsv2 approved these changes

@jimi567 jimi567 jimi567 approved these changes

@takoyakimchi takoyakimchi Awaiting requested review from takoyakimchi takoyakimchi is a code owner

Assignees

@J-I-H-O J-I-H-O

Labels
🖥 backend backend 🧦 chore chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J-I-H-O @jimi567 @ehtjsv2