데모데이 버그 수정 #592
Merged
데모데이 버그 수정 #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cys4585
approved these changes
Sep 30, 2024
jaeml06
approved these changes
Sep 30, 2024
Comment on lines
-4
to
+14
| nonScroll: css` | ||
| nonDrag: css` | ||
| user-select: none; | ||
| `, | ||
| cursorPointer: css` | ||
| cursor: pointer; | ||
| `, | ||
| nonScroll: css` | ||
| &::-webkit-scrollbar { | ||
| display: none; | ||
| } | ||
| `, |
There was a problem hiding this comment.
nonScroll과 nonDrag를 분리해주셨네요. 나중에 해당 설정이 필요할때 편하기 이용가능할 것 같습니다.
| const BASE_URL = `${process.env.BASE_URL}/v1`; | ||
| const API_BASE_URL = `${process.env.API_BASE_URL}/v1`; |
Comment on lines
-13
to
+24
| return <Navigate to={GET_ROUTES.nowDarakbang.main()} />; | ||
| return <Navigate to={GET_ROUTES.nowDarakbang.main()} replace />; | ||
| } | ||
| if (!lastDarakbangId) { | ||
| return <Navigate to={ROUTES.darakbangSelectOption} />; | ||
| return <Navigate to={ROUTES.darakbangSelectOption} replace />; | ||
| } | ||
| } | ||
|
|
||
| if (!token) { | ||
| return <Navigate to={ROUTES.home} />; | ||
| return <Navigate to={ROUTES.home} replace />; | ||
| } | ||
|
|
||
| return <Navigate to={ROUTES.home} />; | ||
| return <Navigate to={ROUTES.home} replace />; |
There was a problem hiding this comment.
각 상황 별로 histroy수정사항 반영 고생했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR의 목적이 무엇인가요?
이슈 ID는 무엇인가요?
설명
env api-url과 baseAPIurl 분리
removeBaseUrl 삭제]
nonDrag,nonScroll 분리
DarakbangInvitationPage- 코드를 복사한 경우 유저 피드백 추가DarakbangInvitationRoute- 참여한 다락방인 경우 분기처리
slashRoute- 뒤로가기 제한