Skip to content

Commit

Permalink
Addressed TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
kungfucraig committed Jan 9, 2025
1 parent 5f23ac6 commit 3739a5b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 9 deletions.
12 changes: 4 additions & 8 deletions src/main/proto/wfa/measurement/reporting/v2alpha/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -420,14 +420,10 @@ kt_jvm_grpc_proto_library(
deps = [":metric_calculation_specs_service_proto"],
)

# TODO(@kungfucraig): Figure out how to have a build rule for the operations service.
# proto_library(
# name = "operations_service_proto",
# srcs = ["???"],
# strip_import_prefix = IMPORT_PREFIX,
# deps = [
# ],
# )
kt_jvm_grpc_proto_library(
name = "operations_service_kt_jvm_grpc_proto",
deps = ["@com_google_googleapis//google/longrunning:operations_proto",],
)

proto_library(
name = "reports_service_proto",
Expand Down
14 changes: 13 additions & 1 deletion src/main/proto/wfa/measurement/reporting/v2alpha/page.proto
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,19 @@ message Page {

// Display name of the component
string display_name = 2 [(google.api.field_behavior) = IMMUTABLE];
// TODO(@kungfucraig): Phase II - Add support for Event Group summaries.

// Summary of an EventGroup entailed by the component
message EventGroupSummary {
string event_group = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.field_behavior) = IMMUTABLE,
(google.api.resource_reference) = {
type: "halo.wfanet.org/EventGroup"
}
];
// TODO(@kungfucraig): Add EventGroup metadata once it has been
// formally encoded in the EventGroup.
}
}

// A summary of each component of the reporting_unit reported on
Expand Down

0 comments on commit 3739a5b

Please sign in to comment.