Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement permissions public api #1989

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

roaminggypsy
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@roaminggypsy roaminggypsy requested a review from SanjayVas January 2, 2025 23:40
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @roaminggypsy)


src/main/kotlin/org/wfanet/measurement/access/service/v1alpha/PermissionsService.kt line 112 at r2 (raw file):

    val internalResponse: InternalListPermissionsResponse =
      internalPermissionStub.listPermissions(

Handle StatusException


src/main/kotlin/org/wfanet/measurement/access/service/v1alpha/PermissionsService.kt line 158 at r2 (raw file):

        internalPermissionStub.checkPermissions(
          internalCheckPermissionsRequest {
            if (request.protectedResource.isNotEmpty()) {

nit: you don't technically need this check, as setting this field to its default value of empty string is equivalent to not setting it

Copy link
Contributor Author

@roaminggypsy roaminggypsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/access/service/v1alpha/PermissionsService.kt line 112 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Handle StatusException

Done.

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)

@roaminggypsy roaminggypsy enabled auto-merge (squash) January 7, 2025 19:46
@roaminggypsy roaminggypsy force-pushed the roaminggypsy-permissions-api branch from 4ee0ab8 to 16bd8de Compare January 7, 2025 19:47
@roaminggypsy roaminggypsy force-pushed the roaminggypsy-permissions-api branch from 16bd8de to bcea0db Compare January 11, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants