-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement permissions public api #1989
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @roaminggypsy)
src/main/kotlin/org/wfanet/measurement/access/service/v1alpha/PermissionsService.kt
line 112 at r2 (raw file):
val internalResponse: InternalListPermissionsResponse = internalPermissionStub.listPermissions(
Handle StatusException
src/main/kotlin/org/wfanet/measurement/access/service/v1alpha/PermissionsService.kt
line 158 at r2 (raw file):
internalPermissionStub.checkPermissions( internalCheckPermissionsRequest { if (request.protectedResource.isNotEmpty()) {
nit: you don't technically need this check, as setting this field to its default value of empty string is equivalent to not setting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/access/service/v1alpha/PermissionsService.kt
line 112 at r2 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Handle StatusException
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 7 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
4ee0ab8
to
16bd8de
Compare
…sary string check in checkPermissions
16bd8de
to
bcea0db
Compare
No description provided.