ppc64le build fixes + ibm-clang #2116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islas
requested changes
Jan 6, 2025
| @@ -771,7 +771,54 @@ CC_TOOLS = $(SCC) | |||
| NETCDFPAR_BUILD = CONFIGURE_NETCDFPAR_BUILD | |||
|
|
|||
| ########################################################### | |||
| #ARCH Linux x86_64 ppc64le, gfortran compiler with gcc #serial smpar dmpar dm+sm | |||
| #ARCH Linux ppc64le, gfortran compiler with gcc #serial smpar dmpar dm+sm | |||
There was a problem hiding this comment.
There is a comment in configure.defaults ( #insert new stanza here) showing where new stanzas should be made. While this may not be entirely new and more of a split up of the x86_64 and ppc64le architectures, certain tests assume the position of stanzas with an emphasis on the specific location of x86_64.
This new ppc64le stanza should be moved lower to the appropriate location.
| @@ -1044,6 +1091,54 @@ RLFLAGS = -c | |||
| CC_TOOLS = $(SCC) | |||
| NETCDFPAR_BUILD = CONFIGURE_NETCDFPAR_BUILD | |||
|
|
|||
| ########################################################### | |||
There was a problem hiding this comment.
This new stanza should also be moved lower to the appropriate location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build files for modern ppc64le, including undefining the "vector" macro and supporting ibm-clang. Previously, the ppc64le build would fail to compile.
TYPE: bug fix
KEYWORDS: ppc64le, gcc, build
SOURCE: Joshua Strodtbeck (Tachos High Performance Computing)
DESCRIPTION OF CHANGES:
Problem:
The old IBM XL compiler has been superseded by ibm-clang. Moreover, both gcc and ibm-clang define a macro called "vector" which causes the preprocessor to fail. Note that this fix depends on islas/cmake-fixSplitCommandFlags, which must be merged first, or the preprocessor fix won't work.
Solution:
Added ibm-clang and ppc64le gcc to
ISSUE: For use when this PR closes an issue.
N/A
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status masterto get formatted list)arch/configure.defaults
TESTS CONDUCTED:
Compiled and ran conus2.5km on my Power9 box.
RELEASE NOTE: The latest IBM compiler, ibm-clang, is now supported.