Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding udm microphysics as option 27 #2147

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dudhia
Copy link
Collaborator

@dudhia dudhia commented Dec 27, 2024

TYPE: new feature

KEYWORDS: UFS Double Moment Microphysics scheme (UDM)

SOURCE: Songyou Hong via internal

DESCRIPTION OF CHANGES:
The new microphysics option is based on 7-class WDM7 and will be mp_physics=27. UDM mp largely adopts microphysical processes in WDM7, but with bug fixes or revisions based on literature and accumulated realism. UDM mp utilizes the in-cloud microphysics concept (Kim and Hong 2018), with the addition of water-friendly aerosols for CCN initialization. Semi-lagrangian sedimentation of Juang and Hong (2010) is also re-configured for computational efficiency and numerical accuracy. All production terms are optimized by introducing a cloud-top definition for hydrometeors.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M phys/Makefile
M phys/module_microphysics_driver.F
M phys/module_physics_init.F
M phys/module_mp_udm.F

TESTS CONDUCTED:

  1. Compilation on derecho Cray Intel (ftn) seems to need -O2.
  2. squall2d_x test case runs OK.
  3. Are the Jenkins tests all passing? Yes.

RELEASE NOTE: UFS Double Moment (UDM) 7-class microphysics from Songyou Hong added (mp_physics=27).

@dudhia dudhia requested review from a team as code owners December 27, 2024 16:21
@dudhia
Copy link
Collaborator Author

dudhia commented Dec 27, 2024

It has failed the tests, so I need to know what happened.

@dudhia
Copy link
Collaborator Author

dudhia commented Dec 28, 2024

forgot to add new module, done now.

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@smileMchen
Copy link
Collaborator

@dudhia
Jimy,
The codes look fine to me and I will approve this PR later.
By the way, is there any information regarding the UDM performance/improvement compared to WDM7? Thanks.

PRESENT( QH_CURR ) .AND. &
PRESENT( QNN_CURR ) .AND. PRESENT ( QNC_CURR ) .AND. &
PRESENT( QNR_CURR ).AND. &
PRESENT( RAINNC ) .AND. PRESENT ( RAINNCV ) ) THEN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still check all these variables' presence if we only have one dynamic core?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is part of a bigger question, but if they are optional in the driver we need these.

@weiwangncar
Copy link
Collaborator

@dudhia Can you or Songyou add some more description to the scheme, especially for its difference and improvements over WDM7? Is the computation speed improved?

@Songyou184
Copy link

UDM mp largely adopts microphysical processes in WDM7, but with
bug fixes or revisions based on literature and accumulated realism.
UDM mp utilizes the in-cloud microphysics concept (kim and hong 2018), with the addition of water-friendly aerosols for CCN initialization. Semi-lagrangian sedimentation of juang and hong (2010) is also re-configured for computational efficiency and numerical accuracy. All production terms are optimized by introducing a cloud-top definition for hydrometeors.

@weiwangncar
Copy link
Collaborator

@dudhia @Songyou184 I took the liberty and added it to the PR itself. It may be useful to add it to the release notes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants