Skip to content

Commit

Permalink
Disable expire_s3_objects call in delete_all_assets (used by delete_v…
Browse files Browse the repository at this point in the history
…ersion)

We still don't have permissions correct for doing the needed
PutBuckedLifecycleConfiguration operation done by expire. And the failed
background job is causing the main delete request to fail with a 504.
(Same for deleting tile caches directly.)
  • Loading branch information
danscales authored and manukala6 committed May 15, 2024
1 parent b05b0ea commit 3cbf8b4
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion app/tasks/delete_assets.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
async def delete_all_assets(dataset: str, version: str) -> None:
await delete_database_table_asset(dataset, version)
delete_s3_objects(DATA_LAKE_BUCKET, f"{dataset}/{version}/")
expire_s3_objects(TILE_CACHE_BUCKET, f"{dataset}/{version}/")

# We don't yet have the correct PutBucketLifecycleConfiguration permission for
# this expire_s3_objects call. The failure of this background task somehow causes
# the main delete request to return a network error (504)
#expire_s3_objects(TILE_CACHE_BUCKET, f"{dataset}/{version}/")
flush_cloudfront_cache(TILE_CACHE_CLOUDFRONT_ID, [f"/{dataset}/{version}/*"])


Expand Down

0 comments on commit 3cbf8b4

Please sign in to comment.