Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTC-2580: Make vector rasterization more robust by using latest PixETL version #440

Merged
merged 8 commits into from
Nov 22, 2023

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Nov 21, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Rasterizing vector data sets with complicated geometry (WDPA for example) sometimes fails (and crashes the DB)

Issue Number: GTC-2580

What is the new behavior?

  • Uses a new PixETL version which is gentler on the DB, limiting parallelization when interacting with it. It also implements some retry logic to make process more robust should the DB crash
  • Minor refactoring/cleanup to the associated test

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR increments the version of PixETL in use to that made after merging this PR: wri/gfw_pixetl#169

@dmannarino dmannarino changed the title GTC-2580: Make vector rasterization more robust by using latest pixetl version GTC-2580: Make vector rasterization more robust by using latest PixETL version Nov 21, 2023
Copy link
Collaborator

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Though just to make sure - this is not just bumping the PixETL version - you are also changing or cleaning up a rasterization test. I assume you intended to do this, even though it's not in the description of the pull request?

@dmannarino
Copy link
Member Author

Seems fine. Though just to make sure - this is not just bumping the PixETL version - you are also changing or cleaning up a rasterization test. I assume you intended to do this, even though it's not in the description of the pull request?

You are correct. Thank you for asking, and my apologies for failing to mention it! Will update for posterity.

@dmannarino dmannarino merged commit 64e1cfb into develop Nov 22, 2023
2 checks passed
@dmannarino dmannarino deleted the gtc-2580_robustify_vector_tiles branch November 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants