GTC-2576 Restrict queries on licensed WDPA dataset - merge to master #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the protection correct, now that I understand FastAPI and its dependencies better. The checking for whether the dataset is protected must occur within a dependency function, since only a dependency function for a path handler has access to the bearer token. Added in protection for GET query/json, GET query/csv, and their less-used POST equivalents.
Responding to PR comments.
solomon-negusse
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTC-2576 Restrict queries on licensed WDPA dataset (2nd try)
Make the protection correct, now that I understand FastAPI and its
dependencies better. The checking for whether the dataset is protected
must occur within a dependency function, since only a dependency
function for a path handler has access to the bearer token.
Added in protection for GET query/json, GET query/csv, and
their less-used POST equivalents.
Tested on staging, and it protected wdpa_licensed_protected_areas, but
I could query if I had the bearer token.