Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect specified order of fields, add option for tile_id for 1x1 vector export #459

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Jan 11, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • If one specifies fields to include in a 1x1 vector file, the fields are put in the file according to the order of the fields in the DB, rather than the order specified by the user.
  • There is no option to include the tile ID of a feature

Issue Number: N/A

What is the new behavior?

  • If one specifies fields to include in a 1x1 vector file, they are included in the order specified by the user
  • There is an option to include the tile_id in which each feature lies

Does this introduce a breaking change?

  • Yes
  • No

Other information

@dmannarino dmannarino changed the title WIP: Preserve specified order of fields for 1x1 vector export Preserve specified order of fields for 1x1 vector export Jan 12, 2024
@dmannarino dmannarino changed the title Preserve specified order of fields for 1x1 vector export Preserve specified order of fields, add option for tile_id for 1x1 vector export Jan 12, 2024
@dmannarino dmannarino marked this pull request as ready for review January 12, 2024 07:38
@dmannarino dmannarino changed the title Preserve specified order of fields, add option for tile_id for 1x1 vector export Respect specified order of fields, add option for tile_id for 1x1 vector export Jan 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b63f243) 80.28% compared to head (63c0ab5) 80.32%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    80.28%   80.32%   +0.03%     
===========================================
  Files          124      124              
  Lines         5509     5515       +6     
===========================================
+ Hits          4423     4430       +7     
+ Misses        1086     1085       -1     
Flag Coverage Δ
unittests 80.32% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice that you fixed up a bunch of comments, and also added several tests!

@dmannarino dmannarino merged commit 88a3334 into develop Jan 12, 2024
2 checks passed
@dmannarino dmannarino deleted the tweaks_for_gadm branch January 12, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants