Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core libs #480

Merged
merged 29 commits into from
Jul 10, 2024
Merged

Update core libs #480

merged 29 commits into from
Jul 10, 2024

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Mar 1, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Update fastapi, etc. to recent versions

What is the current behavior?

Core libraries are ancient

Issue Number: GTC-2705

What is the new behavior?

  • Core libraries are most recent versions
  • I broke apart some tests and refactored some fixtures
  • I introduced a lifespan function in place of separate startup/shutdown functions, because that's how fastapi wants us to do things now.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Base automatically changed from moto_tweaks_for_testing to develop May 13, 2024 16:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (66ccef6) to head (c7e8dc4).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #480      +/-   ##
===========================================
- Coverage    81.95%   81.92%   -0.03%     
===========================================
  Files          126      126              
  Lines         5685     5688       +3     
===========================================
+ Hits          4659     4660       +1     
- Misses        1026     1028       +2     
Flag Coverage Δ
unittests 81.92% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmannarino dmannarino marked this pull request as ready for review July 4, 2024 19:31
@dmannarino dmannarino merged commit 75673ac into develop Jul 10, 2024
2 checks passed
@dmannarino dmannarino deleted the update_core_libs branch July 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants