Develop #499
Merged
Develop #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache _get_data_env results for 5 minutes
We currently delete all datalake files, but have not been deleting the tile cache files in s3://gfw-tiles. The expire_s3_objects() function seems to work, since it is already used when deleting only a static vector tile cache or a raster tile cache. Now that expire_s3_objects is being called when we delete a version, I needed to add in a monkeypatch for expire_s3_objects() in create_vector_source_version() and generic_raster_version() for the tests_v2 tests.
GTC-2708 Expire all tile cache files when deleting a dataset version
have dev branches share load balancer and api gateway stage
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
=======================================
Coverage 81.80% 81.81%
=======================================
Files 124 124
Lines 5536 5537 +1
=======================================
+ Hits 4529 4530 +1
Misses 1007 1007
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dmannarino
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information