GTC-2027 (part 2) - give useful error when input geometry is not Polygon/MultiPolygon #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gon/MultiPolygon This is to fix some more "tuple index out of range" 500 errors. My previous fix was for usual queries. This fix is for zonal statistics calls. (which have been deprecated for quite a while - should we just disable zonal statistics queries sometime soon?)
jterry64
approved these changes
May 2, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #504 +/- ##
===========================================
- Coverage 81.81% 81.78% -0.03%
===========================================
Files 124 124
Lines 5537 5539 +2
===========================================
Hits 4530 4530
- Misses 1007 1009 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTC-2027 (part 2) - give useful error when input geometry is not Polygon/MultiPolygon
This is to fix for a bunch more "tuple index out of range" 500 errors that are showing up. Someone is submitting zonal statistic queries on geometries which are not Polygons. This is the same as my previous fix for normal queries.
Since zonal statististics are on the way out (eventually), I didn't add a new test for this particular error case.