Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable expire_s3_objects call in delete_all_assets (used by delete_version) #511

Merged
merged 1 commit into from
May 8, 2024
Merged

Disable expire_s3_objects call in delete_all_assets (used by delete_version) #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/tasks/delete_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@
async def delete_all_assets(dataset: str, version: str) -> None:
await delete_database_table_asset(dataset, version)
delete_s3_objects(DATA_LAKE_BUCKET, f"{dataset}/{version}/")
expire_s3_objects(TILE_CACHE_BUCKET, f"{dataset}/{version}/")

# We don't yet have the correct PutBucketLifecycleConfiguration permission for
# this expire_s3_objects call. The failure of this background task somehow causes
# the main delete request to return a network error (504)
#expire_s3_objects(TILE_CACHE_BUCKET, f"{dataset}/{version}/")
flush_cloudfront_cache(TILE_CACHE_CLOUDFRONT_ID, [f"/{dataset}/{version}/*"])


Expand Down
Loading