Data Manager #518
Merged
Data Manager #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add owner_id column to datasets
add permissions docs
Write owner_id on new dataset creation
…_protect_dataset_endpoints
Pass user details when authenticating instead of a bool, check for manager on dataset creation
GTC-2794: Only owner or admin can use mutate dataset endpoints
Make use of get_owner in the asset operations. The checks for the pure asset operations were slightly trickier than dataset/version operations, because the dataset name is available in the URL path. You need to do a DB operation to get the dataset name. So, I put the actual get_owner() call in the main function rather than in a Depends() argument. I didn't try to add a new Depends() function that magically does the DB operation, since some of the functions already do the DB operation for other reasons. Updated the test for update_metadata and update_field_metadata to test success and failure cases for different users. Added a missing check for the ADMIN role in get_owner() and updated its comment. Updated the detail of the various permission exceptions to be more informative (GTC-2795). Let me know what you think. We could put a bit more information in these messages if we did these errors in the main functions, rather than in the Depends functions, but that is probably not worth it. In test_dataset.py, several tests were being skipped unintentionally because they were missing the '@pytyest.mark.asyncio' annotation, so I added that in where needed.
Check for owner on version updates
fix data manager logic
Feature/data manager user fix
point to production rw api - needed for interacting with users
GTC-2822 Check for dataset ownership on asset requests
Allow reassigning data owner.
jterry64
requested review from
gtempus,
solomon-negusse,
danscales,
dmannarino and
manukala6
danscales
approved these changes
May 14, 2024
solomon-negusse
approved these changes
May 14, 2024
dmannarino
approved these changes
May 14, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #518 +/- ##
===========================================
- Coverage 81.79% 81.69% -0.11%
===========================================
Files 124 125 +1
Lines 5538 5610 +72
===========================================
+ Hits 4530 4583 +53
- Misses 1008 1027 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Only admins with "gfw" app can manage datasets.
Issue Number: GTC-2791
What is the new behavior?
Does this introduce a breaking change?
Other information