GTC-2788 Do proper serialization for UUIDs #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in case there is a unusual query that does SELECT(*) on a dataset that has a UUID field. Currently, we get a 500 with an error "TypeError: Type is not JSON serializable: asyncpg.pgproto.pgproto.UUID". We need to force UUID to str so it can be serialized, just as we are already doing with Decimal. https://stackoverflow.com/questions/64395136/typeerror-object-of-type-uuid-is-not-json-serializable
solomon-negusse
approved these changes
May 14, 2024
dmannarino
approved these changes
May 14, 2024
jterry64
approved these changes
May 14, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #519 +/- ##
========================================
Coverage 81.69% 81.69%
========================================
Files 125 125
Lines 5610 5610
========================================
Hits 4583 4583
Misses 1027 1027
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTC-2788 Do proper serialization for UUIDs
This is in case there is a unusual query that does SELECT(*) on a dataset that has a UUID field. Currently, we get a 500 with an error "TypeError: Type is not JSON serializable: asyncpg.pgproto.pgproto.UUID".
We need to force UUID to str so it can be serialized, just as we are already doing with Decimal.
https://stackoverflow.com/questions/64395136/typeerror-object-of-type-uuid-is-not-json-serializable
I don't see any easy way to test via tests or in dev (need a dataset with UUID field in it), but will test on real datasets once this is in staging.