Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiles_info endpoint #526

Closed
wants to merge 2 commits into from
Closed

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented May 22, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • There is now a /assets/{asset_id}/tiles_info endpoint for raster tile set assets, which gives a redirect to the tiles.geojson file in S3.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.61%. Comparing base (3cb83d7) to head (eef8d90).

Files Patch % Lines
app/routes/assets/asset.py 41.66% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #526      +/-   ##
===========================================
- Coverage    81.70%   81.61%   -0.10%     
===========================================
  Files          125      125              
  Lines         5615     5624       +9     
===========================================
+ Hits          4588     4590       +2     
- Misses        1027     1034       +7     
Flag Coverage Δ
unittests 81.61% <41.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmannarino dmannarino marked this pull request as ready for review May 23, 2024 14:16
@dmannarino
Copy link
Member Author

Merged as hotfix instead.

@dmannarino dmannarino closed this May 28, 2024
@dmannarino dmannarino deleted the add_tiles_info_endpoint branch May 28, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants