COG pipeline #534
COG pipeline #534
Conversation
jterry64
requested review from
gtempus,
solomon-negusse,
danscales,
dmannarino and
manukala6
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #534 +/- ##
===========================================
+ Coverage 81.71% 81.90% +0.18%
===========================================
Files 125 126 +1
Lines 5618 5671 +53
===========================================
+ Hits 4591 4645 +54
+ Misses 1027 1026 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| "default", | ||
| description="Name space to use for COG. " | ||
| "This will be part of the URI and will " | ||
| "allow to create multiple COGs per version,", |
There was a problem hiding this comment.
Optional: Change "... per version," to "... per version" (get rid of extra comma). Also, maybe change:
"allow to create multiple COGs per version"
to
"allow creation of multiple COGs per version".
app/models/pydantic/jobs.py
Outdated
| @@ -134,6 +137,19 @@ class PixETLJob(Job): | |||
| attempt_duration_seconds = int(DEFAULT_JOB_DURATION * 1.5) | |||
|
|
|||
|
|
|||
| class GDALCOGJob(Job): | |||
| """Use for raster transformations using GDAL Python docker in PixETL | |||
There was a problem hiding this comment.
I think better described as:
"""Use for creating COG files using GDAL Python docker in PixETL queue"""
app/utils/path.py
Outdated
| @@ -66,6 +66,8 @@ def get_asset_uri( | |||
| uri_constructor: Dict[str, str] = { | |||
| AssetType.dynamic_vector_tile_cache: f"{TILE_CACHE_URL}/{dataset}/{version}/dynamic/{{z}}/{{x}}/{{y}}.pbf", | |||
| AssetType.static_vector_tile_cache: f"{TILE_CACHE_URL}/{dataset}/{version}/{implementation}/{{z}}/{{x}}/{{y}}.pbf", | |||
| # AssetType.cog: f"{TILE_CACHE_URL}/{dataset}/{version}/{implementation}/{{z}}/{{x}}/{{y}}.png", | |||
There was a problem hiding this comment.
Remove this commented out path, unless you think it might be used later?
batch/scripts/get_arguments.sh
Outdated
| SRID="$2" | ||
| shift # past argument | ||
| shift # past value | ||
| ;; |
There was a problem hiding this comment.
Was this new --srid ever used? I don't see it used in cogify.sh
There was a problem hiding this comment.
We ended up removing it, good catch!
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the new behavior?
Create COG assets with specified projection and block size. This creates just one big COG file for all the times.
Does this introduce a breaking change?