GTC-2868 Force use of only XY (2 dimensions) from the dataset

[danscales]

GTC-2868 Force use of only XY (2 dimensions) from the dataset

Added "-dim xy" (same as "-dim 2") to the ogr2ogr command line.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (c9bcbf5) to head (b0b229f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #547   +/-   ##
========================================
  Coverage    82.03%   82.03%           
========================================
  Files          126      126           
  Lines         5665     5665           
========================================
  Hits          4647     4647           
  Misses        1018     1018           

Flag	Coverage Δ
unittests	82.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dmannarino]

Change looks good! How hard would it be to have a test for the CSV case at least?

[danscales]

Change looks good! How hard would it be to have a test for the CSV case at least?

Maanas indicated to me that the 3-dimension problem wasn't relevant for CSV or wasn't needed, so I didn't make any changes to load_vector_csv_data.sh. So, can't do a test on that. I tested this in dev using the dataset that Maanas gave to me (s3://gfw-data-lake-dev/landmark_icls_pt/v202406/raw/CommunityLevelData_pt.zip ) and will test again once this change is in staging.

[manukala6]

@dmannarino According to TableAssetCreationOptions there are specific lat/long columns for ingesting CSVs, so by definition they should be 2 dimensions

[danscales]

Thanks for the reviews!