GTC-2864 Make test output for Data API be less verbose by default #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I change both script/test and script/test_v2 to not show warnings or do/show code coverage by default. So, the actual test results won't scroll off the screen in the output when running a single or few tests. Also, I added an option to cause stdout of the tests to be displayed, so that you can see debugging print() calls when running tests, even if the test succeeds. (Normally all output of a test is captured and not displayed if the test succeeds.) New options (all off by default): --do-cov - Run code coverage and display it after the test results --show-warning - Show python warnings when compiling tests --show-stdout - Show output of successful tests
danscales
requested review from
solomon-negusse,
jterry64,
dmannarino and
manukala6
If you are specifying specific test files for scripts/test or scripts/test_v2, now include the relative catch from the the top of the repo (don't drop tests/ or tests_v2). Will make file completion of the test file names from the shell be usable. Also, enable --show-warnings for the the tests run in the Github actions.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #548 +/- ##
========================================
Coverage 82.03% 82.03%
========================================
Files 126 126
Lines 5665 5665
========================================
Hits 4647 4647
Misses 1018 1018
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTC-2864 Make test output for Data API be less verbose
I changed both script/test and script/test_v2 to not show warnings or
do/show code coverage by default. So, the actual test results won't
scroll off the screen in the output when running a single or few tests.
Also, I added an option to cause stdout of the tests to be displayed, so
that you can see debugging print() calls when running tests, even if the
test succeeds. (Normally all output of a test is captured and not
displayed if the test succeeds, which makes sense when not debugging.)
New options (all off by default):
--do-cov - Run code coverage and display it after the test results
--show-warning - Show python warnings when compiling tests
--show-stdout - Show output of successful tests
Definitely feel free to comment on other ways to improve the Data API test output.