Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SPARSE_OK=TRUE for COGs #577

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Set SPARSE_OK=TRUE for COGs #577

merged 2 commits into from
Aug 22, 2024

Conversation

jterry64
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Header is too big for integrated alerts COG

Issue Number: N/A

What is the new behavior?

Set SPARSE_OK=TRUE to reduce header size.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@jterry64 jterry64 requested a review from danscales August 19, 2024 22:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (c79cfff) to head (d955884).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   81.93%   81.93%           
=======================================
  Files         126      126           
  Lines        5697     5697           
=======================================
  Hits         4668     4668           
  Misses       1029     1029           
Flag Coverage Δ
unittests 81.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@danscales danscales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this reduces the metadata enough!

@jterry64 jterry64 merged commit 0fb62e6 into master Aug 22, 2024
2 checks passed
@jterry64 jterry64 deleted the sparse_ok_hotifx branch August 22, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants