Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge up OTF Lists feature #578

Merged
merged 19 commits into from
Aug 21, 2024
Merged

Merge up OTF Lists feature #578

merged 19 commits into from
Aug 21, 2024

Conversation

dmannarino
Copy link
Member

@dmannarino dmannarino commented Aug 21, 2024 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

jterry64 and others added 19 commits August 7, 2024 12:05
@jterry64
Query on OTF List (#560)
ae21eaa
@danscales
Added documentation for the /query/batch route
8513f91 
Including some documentation on the arguments.
@danscales
Improvements based on Justin's comments.
0f8c53f
@danscales
Doc fixes, responding to Daniel's comments.
d9390d9
@jterry64
Enable API key for /query/batch
25d0708
@danscales
Respond to other comment from Daniel
ee03788
@danscales
Merge branch 'develop' into gtc-2920
8a15c6b
@danscales
Merge pull request #567 from wri/gtc-2920
82850ef 
GTC-2920 Added documentation for the /query/batch route
@solomon-negusse
add doc about batch analysis
a2122ff
@solomon-negusse
attach lambda to allow passing api key as query parameter
50f65a6
@solomon-negusse
update docs
0b0786f
@solomon-negusse
Merge pull request #571 from wri/doc/list-otf
0fe58c1 
Doc/list otf
@danscales
GTC-2939 Add job_link to OTF list response
59b11f8 
This gives the full URL for fetching the current job status.
@danscales
Fix to add job_link to OTF query response, not /job response
120aa7c
@danscales
Merge pull request #573 from wri/job_link
e9041cf 
GTC-2939 Add job_link to OTF list response
@danscales
Show associated error message in job info if status is 'error'.
fc18d5f
@danscales
Merge pull request #574 from wri/show_error_message
ae83db0 
Show associated error message in job info if status is 'error' for a OTF list request
@danscales
Handle case in _get_progress where map runs haven't started yet
13cb2a2 
If we're still in pre-processing, the map runs haven't started yet, so
we need to deal with case where there are no map run entries yet, else
there will be an exception/Internal Server Error
@danscales
Merge pull request #575 from wri/check_map_runs
1fd445a 
Handle case in _get_progress where map runs haven't started yet
@dmannarino dmannarino merged commit 85094ee into master Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterry64 jterry64 jterry64 approved these changes

@danscales danscales Awaiting requested review from danscales

@manukala6 manukala6 Awaiting requested review from manukala6

@solomon-negusse solomon-negusse Awaiting requested review from solomon-negusse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmannarino @jterry64 @danscales @solomon-negusse