Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore behaviour of naming VTC layers after dataset #579

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

dmannarino
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • All vector tile cache layers were being named "data" instead of after the dataset name

Issue Number: GTC-2949

What is the new behavior?

  • All vector tile cache layers are named after the dataset name. Possibly not what we want in the end, but this was the previous behavior, which people expect

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • Actually, we weren't specifying the layer name before, tippecanoe was using the dataset name because that's what we named the JSON file after. It looks like we DO allow clients to specify a layer name, but ignore it. But that's another ticket...

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (1fd445a) to head (c567610).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #579   +/-   ##
========================================
  Coverage    81.15%   81.15%           
========================================
  Files          128      128           
  Lines         5820     5820           
========================================
  Hits          4723     4723           
  Misses        1097     1097           
Flag Coverage Δ
unittests 81.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmannarino dmannarino merged commit 7f2be86 into develop Aug 27, 2024
2 checks passed
@dmannarino dmannarino deleted the fix_vector_layer_names branch August 27, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants