Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version metadata bug #580

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix version metadata bug #580

merged 3 commits into from
Aug 28, 2024

Conversation

solomon-negusse
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

in version metadata, date validation error is ignored

What is the new behavior?

Raise 422 http error when date fields fail validation

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (7f2be86) to head (6f89964).

Files Patch % Lines
app/models/pydantic/metadata.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #580      +/-   ##
===========================================
- Coverage    81.15%   81.12%   -0.04%     
===========================================
  Files          128      128              
  Lines         5820     5821       +1     
===========================================
- Hits          4723     4722       -1     
- Misses        1097     1099       +2     
Flag Coverage Δ
unittests 81.12% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@solomon-negusse solomon-negusse merged commit 9cadb7c into develop Aug 28, 2024
2 checks passed
@solomon-negusse solomon-negusse deleted the fix-version-metadata-bug branch August 28, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants