use TestMessageProxy for assert receive tests

wyeworks · Aug 23, 2024 · 5eac749 · 5eac749
1 parent fc968f4
commit 5eac749
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 20 deletions.
diff --git a/test/unit/error_info_test.exs b/test/unit/error_info_test.exs
@@ -39,7 +39,7 @@ defmodule ErrorInfoTest do
       options: [
         mailer: Support.BambooFakeMailer,
         from: "[email protected]",
-        to: to_string(ErrorInfoTest),
+        to: to_string(BoomNotifier.TestMessageProxy),
         subject: "BOOM error caught"
       ]
 
@@ -71,7 +71,6 @@ defmodule ErrorInfoTest do
   end
 
   setup do
-    Process.register(self(), ErrorInfoTest)
     Logger.metadata(name: "Dennis", age: 17)
   end
 

diff --git a/test/unit/mailer_notifier_test.exs b/test/unit/mailer_notifier_test.exs
@@ -68,7 +68,7 @@ defmodule MailerNotifierTest do
           options: [
             mailer: @fake_mailer_module,
             from: "[email protected]",
-            to: to_string(MailerNotifierTest),
+            to: to_string(BoomNotifier.TestMessageProxy),
             subject: "BOOM error caught"
           ],
           custom_data: [:assigns, :logger]
@@ -101,7 +101,7 @@ defmodule MailerNotifierTest do
           options: [
             mailer: @fake_mailer_module,
             from: "[email protected]",
-            to: to_string(MailerNotifierTest),
+            to: to_string(BoomNotifier.TestMessageProxy),
             subject: "BOOM error caught",
             max_subject_length: 25
           ]
@@ -115,7 +115,6 @@ defmodule MailerNotifierTest do
       :elixir_config.put(:ignore_module_conflict, false)
 
       setup do
-        Process.register(self(), MailerNotifierTest)
         Logger.metadata(name: "Dennis", age: 17)
 
         on_exit(&flush_messages/0)
@@ -158,7 +157,7 @@ defmodule MailerNotifierTest do
       test "Set email using proper from and to addresses" do
         conn = conn(:get, "/")
         catch_error(TestRouter.call(conn, []))
-        email_to = MailerNotifierTest |> to_string()
+        email_to = BoomNotifier.TestMessageProxy |> to_string()
 
         assert_receive({:email_from, "[email protected]"}, @receive_timeout)
         assert_receive({:email_to, ^email_to}, @receive_timeout)

diff --git a/test/unit/notification_sender_test.exs b/test/unit/notification_sender_test.exs
@@ -10,12 +10,11 @@ defmodule BoomNotifier.NotificationSenderTest do
   }
 
   @throttle_timeout 500
-  @pid_name __MODULE__
   @receive_timeout 100
 
   @settings_basic [
     notifier: __MODULE__.NotificationSenderTestNotifier,
-    options: [pid_name: @pid_name]
+    options: [pid_name: BoomNotifier.TestMessageProxy]
   ]
 
   @settings_groupping @settings_basic ++
@@ -47,7 +46,6 @@ defmodule BoomNotifier.NotificationSenderTest do
   end
 
   setup do
-    self() |> Process.register(@pid_name)
     clear_error_storage()
 
     on_exit(&flush_messages/0)

diff --git a/test/unit/notifier_test.exs b/test/unit/notifier_test.exs
@@ -5,6 +5,8 @@ defmodule NotifierTest do
   import ExUnit.CaptureLog
   import TestUtils
 
+  alias BoomNotifier.TestMessageProxy
+
   doctest BoomNotifier
 
   @receive_timeout 500
@@ -62,7 +64,7 @@ defmodule NotifierTest do
       notifier: FakeNotifier,
       options: [
         subject: "BOOM error caught",
-        sender_pid_name: NotifierTest
+        sender_pid_name: TestMessageProxy
       ]
 
     def call(_conn, _opts) do
@@ -77,7 +79,7 @@ defmodule NotifierTest do
           notifier: FakeNotifier,
           options: [
             subject: "BOOM error caught",
-            sender_pid_name: NotifierTest
+            sender_pid_name: TestMessageProxy
           ]
         ]
       ]
@@ -92,7 +94,7 @@ defmodule NotifierTest do
       notifier: FakeNotifier,
       options: [
         subject: "BOOM error caught",
-        sender_pid_name: NotifierTest
+        sender_pid_name: TestMessageProxy
       ]
 
     def call(_conn, _opts) do
@@ -105,7 +107,7 @@ defmodule NotifierTest do
       notifier: FakeNotifier,
       options: [
         subject: "BOOM error caught",
-        sender_pid_name: NotifierTest
+        sender_pid_name: TestMessageProxy
       ]
 
     def call(_conn, _opts) do
@@ -119,7 +121,7 @@ defmodule NotifierTest do
       notification_trigger: :exponential,
       options: [
         subject: "BOOM error caught",
-        sender_pid_name: NotifierTest
+        sender_pid_name: TestMessageProxy
       ]
 
     def call(_conn, _opts) do
@@ -133,7 +135,7 @@ defmodule NotifierTest do
       notification_trigger: [exponential: [limit: 3]],
       options: [
         subject: "BOOM error caught",
-        sender_pid_name: NotifierTest
+        sender_pid_name: TestMessageProxy
       ]
 
     def call(_conn, _opts) do
@@ -154,7 +156,6 @@ defmodule NotifierTest do
   end
 
   setup do
-    Process.register(self(), NotifierTest)
     clear_error_storage()
 
     on_exit(&flush_messages/0)
@@ -359,7 +360,7 @@ defmodule NotifierTest do
         notifier: FakeNotifier,
         options: [
           subject: "BOOM error caught",
-          sender_pid_name: NotifierTest
+          sender_pid_name: TestMessageProxy
         ],
         ignore_exceptions: [TestException]
 
@@ -373,7 +374,7 @@ defmodule NotifierTest do
         notifier: FakeNotifier,
         options: [
           subject: "BOOM error caught",
-          sender_pid_name: NotifierTest
+          sender_pid_name: TestMessageProxy
         ],
         ignore_exceptions: [TestException]
 
@@ -402,14 +403,14 @@ defmodule NotifierTest do
       use Plug.ErrorHandler
 
       def handle_errors(_conn, _error) do
-        test_pid = Process.whereis(NotifierTest)
+        test_pid = Process.whereis(TestMessageProxy)
         send(test_pid, :handle_errors_called)
       end
 
       use BoomNotifier,
         notifier: FakeNotifier,
         options: [
-          sender_pid_name: NotifierTest
+          sender_pid_name: TestMessageProxy
         ]
 
       def call(_conn, _opts) do