Skip to content

Commit

Permalink
Remove walkthrough_notifiers from use BoomNotifier
Browse files Browse the repository at this point in the history
Make accumulated_occurrences testing more clear
  • Loading branch information
joaquinco committed Aug 29, 2024
1 parent 9047686 commit 98ff12e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/boom_notifier.ex
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ defmodule BoomNotifier do
fn notifier, options -> BoomNotifier.Api.validate_notifiers(notifier, options) end
)

def walkthrough_notifiers(callback) do
unquote(config) |> BoomNotifier.Api.walkthrough_notifiers(callback)
end

def notify_error(conn, error) do
BoomNotifier.Api.notify_error(unquote(config), conn, error)
end
Expand Down
2 changes: 2 additions & 0 deletions test/unit/notification_sender_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ defmodule BoomNotifier.NotificationSenderTest do
NotificationSender.trigger_notify(@settings_groupping, error_info)
end

assert_receive({:notify_called, %{occurrences: %{accumulated_occurrences: 1}}})
assert_receive({:notify_called, %{occurrences: %{accumulated_occurrences: 2}}})
assert_receive({:notify_called, %{occurrences: %{accumulated_occurrences: 4}}})
end
end
Expand Down

0 comments on commit 98ff12e

Please sign in to comment.