Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Remove end to end test from lib and distribution package #96

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

joaquinco
Copy link
Contributor

Remove mix task from lib so it's not included in the realeased package.

@iaguirre88
Copy link
Member

For some reason this change is not reporting an error on the CI even thought a test seems to have failed 🤔

image

Would you mind taking another look?

@iaguirre88
Copy link
Member

It's reporting the error now 🙌
I think if we rebase with master now it will pass the test

@joaquinco joaquinco force-pushed the chore/remove-e2e-from-lib branch from dfcda47 to c5ef4da Compare September 4, 2024 17:17
Copy link
Member

@iaguirre88 iaguirre88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸🎸

@iaguirre88 iaguirre88 merged commit d22b680 into wyeworks:master Sep 5, 2024
27 checks passed
@joaquinco joaquinco deleted the chore/remove-e2e-from-lib branch September 5, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants