[OSU-114] Setup sanger enabled service #4925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquinco
changed the title
diebas
approved these changes
Jan 15, 2025
| if sanger_external_service.blank? | ||
| Service.transaction do | ||
| external_service = UrlService.find_or_create_by( | ||
| location: new_sanger_sequencing_submission_path |
There was a problem hiding this comment.
While this should still work, I think it's better to use the url, so the users see the complete URL (including domain)
There was a problem hiding this comment.
Yeap this work. The only reason I can think of for having the domain for internal routes is end users being accustomed to see it. I'll change it anyway
config/locales/en.controllers.yml
Outdated
Comment on lines
218
to
219
| sanger_sequencing_enabled: Sanger has been enabled, make sure the Order Form is inactive | ||
| sanger_sequencing_disabled: Sanger has been disabled, make sure the Order Form is active |
There was a problem hiding this comment.
nit: should we add the period at the end of the messages?
| @@ -62,4 +62,34 @@ | |||
| context "when billing mode is Skip Review" do | |||
| include_examples "creates a product with billing mode", "service", "Skip Review" | |||
| end | |||
|
|
|||
| context "when sanger enable si checked" do | |||
LeticiaErrandonea
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
sanger_sequencing_enabledto productScreenshots