Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings screen rewrite #510

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 15, 2024

Settings screen rewrite

This pull request completely rewrites settings screen to be more maintainable, user-friendly and accessible.

image

Short list of changes:

  • Complete code rewrite with lots of improvements in readability and logic inspired by Sodium and YACL approaches
  • New, more compact and nicer layout for settings, brighter colors
  • New tooltip look with fancy gradient
  • New search field that will help to find any needed option. You can filter them by name, tooltip and current value
  • Keyboard navigation in GUI with Arrow keys and TAB
  • Useful shortcuts like SHIFT+P to get into vanilla settings or CTRL(CMD)+L to focus search field
  • Scrolling strings, Z-axis support for borders and strings and performance improvements in GuiRenderer
  • JAR size improvements: reduced size of icons and logo
  • VideoMode handling refactor and fixes
  • Config refactor and removal of VideoMode from it (saves ~100 bytes!)
  • "Current" option in Fullscreen Resolution that just uses system display settings
  • Translations fixes: removed "Auto" for Device Selector, "Back face culling" -> "Backface Culling" and small grammar and capitalization changes for better consistency

And more... (maybe forgot something)

@ghost ghost marked this pull request as draft September 15, 2024 17:13
@ghost ghost force-pushed the settings-screen-rewrite branch from 358d27b to 79b9e75 Compare September 15, 2024 17:14
@ghost ghost marked this pull request as ready for review September 22, 2024 13:54
@ghost ghost force-pushed the settings-screen-rewrite branch from 814e197 to ab0727f Compare September 28, 2024 15:45
@ghost ghost changed the base branch from 1.20.x to 1.21 September 28, 2024 15:46
@ghost ghost force-pushed the settings-screen-rewrite branch from ab0727f to ad348cb Compare October 13, 2024 04:05
@ghost ghost changed the base branch from 1.21 to dev October 13, 2024 04:05
@ghost ghost force-pushed the settings-screen-rewrite branch from ad348cb to dad85a7 Compare October 14, 2024 16:36
@ghost ghost force-pushed the settings-screen-rewrite branch 2 times, most recently from 5631032 to e55a9e6 Compare November 29, 2024 15:04
@ghost ghost force-pushed the settings-screen-rewrite branch from e55a9e6 to 89ea69c Compare November 29, 2024 15:17
@ghost ghost closed this by deleting the head repository Dec 21, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants