CP-49775 convert SMGC to systemd service #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkSymsCtx
requested changes
Jun 13, 2024
TimSmithCtx
force-pushed
the
private/timsmi/CP-49775
branch
from
578b389 to
0134203
Compare
MarkSymsCtx
requested changes
Jun 13, 2024
TimSmithCtx
force-pushed
the
private/timsmi/CP-49775
branch
2 times, most recently
from
2f4c150 to
1b905ac
Compare
MarkSymsCtx
requested changes
Jun 14, 2024
Add a templated oneshot service and use systemctl to start it. The systemctl command is invoked with "--no-wait" so that it returns immediately because the "oneshot" nature of the service would otherwise wait until the command completes. Note that because the service is a oneshot with RemainAfterExit=no (so we can multiply start it), it will go from "activating" to "dead" without ever appearing to be "running". Signed-off-by: Tim Smith <[email protected]>
TimSmithCtx
force-pushed
the
private/timsmi/CP-49775
branch
from
1b905ac to
ba43133
Compare
MarkSymsCtx
reviewed
Jun 14, 2024
| state = result.stdout.decode('utf-8').rstrip() | ||
| if state == "activating" or state == "running": | ||
| return True | ||
| return False |
There was a problem hiding this comment.
Looks good, do we need to consider the case where systemd is not being used? I'm inclined to say not as I think all consumers of this code are now using systemd
MarkSymsCtx
approved these changes
Jun 14, 2024
MarkSymsCtx
approved these changes
Jun 17, 2024
rdn32
reviewed
Jun 18, 2024
| @@ -3206,6 +3206,10 @@ def gc(session, srUuid, inBackground, dryRun=False): | |||
|
|
|||
|
|
|||
| def start_gc(session, sr_uuid): | |||
There was a problem hiding this comment.
Why is this code being retained? I don't see any callers, and the implementation of get_state implies that we only expect the systemd version to be called?
There was a problem hiding this comment.
Mainly to make it easy for someone who wants to revert to a non-systemd method of doing things to do so
(yes, they'd have to reimplement get-state but the original method of doing so has lock-ordering issues, so leaving it would not have been a service)
rdn32
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a templated oneshot service and use systemctl to start it. The systemctl command is invoked with "--no-wait" so that it returns immediately because the "oneshot" nature of the service would otherwise wait until the command completes.
Note that because the service is a oneshot with RemainAfterExit=no (so we can multiply start it), it will go from "activating" to "dead" without ever appearing to be "running".