Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-400743: perform post snapshot rename in ioretry #715

Merged
merged 1 commit into from
Nov 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion drivers/FileSR.py
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,10 @@ def _snapshot(self, snap_type, cbtlog=None, cbt_consistency=None):
"FileSR_fail_snap1",
self.__fist_enospace)
util.ioretry(lambda: self._snap(tmpsrc, newsrcname))
self._rename(tmpsrc, src)
# SMB3 can return EACCES if we attempt to rename over the
# hardlink leaf too quickly after creating it.
util.ioretry(lambda: self._rename(tmpsrc, src),
errlist=[errno.EIO, errno.EACCES])
if snap_type == VDI.SNAPSHOT_DOUBLE:
# Fault injection site to fail the snapshot with ENOSPACE
util.fistpoint.activate_custom_fn(
Expand Down
Loading