New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SnappyOutputStream write() Length Check for 31-bit Integer Limit #528

Closed

imsudiproy wants to merge 2 commits into xerial:master from imsudiproy:OutputStream

Contributor

imsudiproy commented Oct 19, 2023


          add assert to check length and int limit

cfcfd4c

github-actions bot added the bug label

Owner

xerial commented Dec 1, 2023

I think the syntax doesn't work in JDK8/11. It's better to wrap with paren


          add parentheses

a452d57

Contributor

bokken commented Dec 2, 2023

Asserts are disabled by default. What is the purpose of this change?

imsudiproy closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug