Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old simulator implementation #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove old simulator implementation #345

wants to merge 2 commits into from

Conversation

Endogen
Copy link
Contributor

@Endogen Endogen commented Dec 27, 2024

Description

Removed old simulator implementation since it's not being used anymore

Type of change

Please delete options that are not relevant.

  •  Enhancement (simplifying, beautifying, better performance, etc.)

Checklist

  • I have performed a self-review of my own code
  • I have tested this change in my development environment.
  • I have added tests to prove that this change works
  • All existing tests pass after this change
  • I have added / updated documentation related to this change

@Endogen Endogen self-assigned this Dec 27, 2024
@Endogen Endogen added the enhancement New feature or request label Dec 27, 2024
duelingbenjos
duelingbenjos reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@duelingbenjos duelingbenjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xian-js still uses this, so I'm for leaving it in for now. no reason to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duelingbenjos duelingbenjos duelingbenjos left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Endogen Endogen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Endogen @duelingbenjos