Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msrv-compatible dependencies #3407

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Bump msrv-compatible dependencies #3407

merged 4 commits into from
Dec 26, 2024

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Dec 23, 2024

No description provided.

The packages are apparently missing in ubuntu
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.13%. Comparing base (3c3a26f) to head (3d5ecfc).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
src/api/config/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3407      +/-   ##
==========================================
- Coverage   88.52%   82.13%   -6.40%     
==========================================
  Files          89       89              
  Lines       28323    27407     -916     
==========================================
- Hits        25074    22511    -2563     
- Misses       3249     4896    +1647     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lu-zero lu-zero requested a review from barrbrain December 26, 2024 14:12
Copy link
Collaborator

@barrbrain barrbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. I will find a less brittle solution for arm64 tests.

@lu-zero lu-zero merged commit 62b4888 into xiph:master Dec 26, 2024
24 of 26 checks passed
@lu-zero lu-zero deleted the bump-deps branch December 26, 2024 23:01
@lu-zero
Copy link
Collaborator Author

lu-zero commented Dec 26, 2024

We can test on macos-latest iirc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants