🚑 add a prop 'decimalPlaces' for more flexible use #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xlsdg
Add a prop 'decimalPlaces' for more flexible use.
Just fixed the issue #28 'Decimal places property missing'.
Cause I encountered this scene, too.
But the original property must place in the config, a little bit inflexible when configurate more than one instance.
The modifications are as follows:
decimalPlaces: {
type: Number,
required: ##false,
default: 0,
}
const config = that.decimalPlaces ?
Object.assign({}, that.options, {
decimalPlaces: that.decimalPlaces,
}) :
that.options;
const instance = new CountUp(
dom,
that.endVal,
config
);