Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shardid): added HashRing with consistent hashing for sharding #30

Merged
merged 8 commits into from
Apr 6, 2024

Conversation

cnlangzi
Copy link
Member

@cnlangzi cnlangzi commented Apr 5, 2024

Changes

  • added HashRing with consistent hashing for sharding data by string key

Copy link

deepsource-io bot commented Apr 5, 2024

Here's the code health analysis summary for commits 1acbdae..2de56d2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 4 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

shardid/hash_ring_migrator.go Outdated Show resolved Hide resolved
shardid/hash_ring_migrator_test.go Outdated Show resolved Hide resolved
shardid/hash_ring_test.go Show resolved Hide resolved
shardid/hash_ring_migrator_test.go Outdated Show resolved Hide resolved
shardid/hash_ring.go Show resolved Hide resolved
shardid/hash_ring_migrator.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.67%. Comparing base (1acbdae) to head (4703605).

❗ Current head 4703605 differs from pull request most recent head 2de56d2. Consider uploading reports for the commit 2de56d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   71.49%   73.67%   +2.17%     
==========================================
  Files          37       40       +3     
  Lines        1512     1637     +125     
==========================================
+ Hits         1081     1206     +125     
  Misses        317      317              
  Partials      114      114              
Flag Coverage Δ
Unit-Tests 73.67% <100.00%> (+2.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnlangzi cnlangzi merged commit 2acb436 into main Apr 6, 2024
3 of 4 checks passed
@cnlangzi cnlangzi deleted the feat/hash_shardid branch April 6, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant