Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlbuilder): added OrderBy #32

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat(sqlbuilder): added OrderBy #32

merged 4 commits into from
Apr 10, 2024

Conversation

cnlangzi
Copy link
Member

Changes

  • added OrderByBuilder on Builder.OrderBy

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cnlangzi - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Returning 'true' when 'safeColumns' is nil may introduce SQL injection vulnerabilities. (link)
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🔴 Security: 1 blocking issue
  • 🟡 Testing: 2 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

sqlbuilder_orderby.go Show resolved Hide resolved
sqlbuilder_orderby.go Show resolved Hide resolved
sqlbuilder_orderby.go Show resolved Hide resolved
sqlbuilder_orderby_test.go Show resolved Hide resolved
sqlbuilder_orderby_test.go Show resolved Hide resolved
Copy link

deepsource-io bot commented Apr 10, 2024

Here's the code health analysis summary for commits 65ab358..d4d1232. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.83%. Comparing base (65ab358) to head (d4d1232).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   74.62%   74.83%   +0.21%     
==========================================
  Files          40       41       +1     
  Lines        1671     1701      +30     
==========================================
+ Hits         1247     1273      +26     
- Misses        312      314       +2     
- Partials      112      114       +2     
Flag Coverage Δ
Unit-Tests 74.83% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cnlangzi cnlangzi merged commit 91ead50 into main Apr 10, 2024
7 checks passed
@cnlangzi cnlangzi deleted the feat/orderby branch April 10, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant