chore: refactor findImages to remove print statements

[a1994sc]

Description

Refactor of findImages remove print states from inside the function. It now passes the image map to the devFindImagesCmd which prints a similar table as before.

A regression is that we lost the easy ability add the comment blocks for the maybe images and cosign artifacts.

Related Issue

Relates to #2865

Checklist before merging

• Test, docs, adr added or updated as needed
• Contributor Guide Steps followed

[netlify]

✅ Deploy Preview for zarf-docs canceled.

Name	Link
🔨 Latest commit	9060366
🔍 Latest deploy log	https://app.netlify.com/sites/zarf-docs/deploys/673cf14d60c00100088febb3

[a1994sc]

I was not sure if printing them out with the fmt.Print functions was the correct way to handle this, I did not see a good log level to put it in the logger.

Please let me know if you want me to update this

[phillebaba]

We are currently in the process of refactoring the pacakger function so find images will be completely re-written. During this refactoring printing will be deferred to the CLI.

[a1994sc]

Ah ok, thank you @phillebaba for the clarification. I'm wanting to put some effort into addressing #2865 for automatically updating the zarf.yaml file. Should I assume that findImages will still return an array with the images that zarf discovered still?

[a1994sc]

I can also close this PR if that is preferred for you

[phillebaba]

I am not looking into changing the existing behavior for find images. So the refactor will still in the end print the found images. the difference being is that the exported library will return a slice instead of printing the results. I would suggest bringing up the issue to change the behavior of find images at the next community meeting of possible.

It will be a lot easier to implement this suggested change after the refactor is done.