-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: graph traversals #45
base: master
Are you sure you want to change the base?
Conversation
3ab31c0
to
2b2c6c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 98.18% 98.57% +0.38%
==========================================
Files 9 9
Lines 276 281 +5
==========================================
+ Hits 271 277 +6
+ Misses 5 4 -1
Continue to review full report at Codecov.
|
2b2c6c4
to
c97a1c6
Compare
c97a1c6
to
bc0b64e
Compare
I struggle to use the implicit/explicit graphs in an easy way. Normally I do not care which graph something belongs to but there are cases like when I want to get a label of the type of a node - then I only want to get the exact type from the explicit graph. For my use case it would be great to add the graph when matching things like: What do you think? edit: edit2: |
Hello @martinwebrant. Sorry for late reply. In code where I needed a specific graph, in the current version I would create a new pointer object like: let pointer: GraphPointer
let graph: Term
const pointerAtGraph = cf({ dataset: pointer.dataset, term: pointer.term, graph }) I maintain the typings by the way |
Thanks, I'll do it like that for now! |
I propose this to allow moving pointer(s) between (named) graphs in a dataset
Now that I look at this, I'm a little concerned about literals and blank nodes. While the former would be harmless albeit strange, blank nodes should maybe be excluded from this feature?