Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointed docs links to the new docs #110

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Pointed docs links to the new docs #110

merged 2 commits into from
Jun 11, 2024

Conversation

AlexejPenner
Copy link
Collaborator

No description provided.

@AlexejPenner AlexejPenner requested a review from strickvl June 5, 2024 13:18
@dagshub DagsHub
Copy link

dagshub bot commented Jun 5, 2024

Join the discussion on DagsHub!

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

strickvl
strickvl requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand these changes... you've changed it all to this pattern:

https://docs.zenml.io/stack-components/model-deployers/seldon

whereas it should be:

https://docs.zenml.io/stack-components/component-guide/model-deployers/seldon

@strickvl
Copy link
Contributor

strickvl commented Jun 5, 2024

(for the stack components at least...) there will be other patterns ofc

strickvl
strickvl approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this now, knowing what I know following last week's changes :)

@htahir1
Copy link
Contributor

htahir1 commented Jun 11, 2024

lets merge thsi right @AlexejPenner ?

AlexejPenner
AlexejPenner commented Jun 11, 2024
View reviewed changes
Copy link
Collaborator Author

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@AlexejPenner AlexejPenner merged commit ce94a86 into main Jun 11, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htahir1 htahir1 htahir1 approved these changes

@strickvl strickvl strickvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexejPenner @strickvl @htahir1