Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config and updates for Llama 3.1 #118

Merged
merged 12 commits into from
Jul 24, 2024
Merged

Add config and updates for Llama 3.1 #118

merged 12 commits into from
Jul 24, 2024

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Jul 23, 2024

  • update config
  • update requirements
  • removed gradient checkpointing to make accelerate configs work again
  • update README to showcase the different configs we now have

@strickvl strickvl added enhancement New feature or request internal labels Jul 23, 2024
@strickvl strickvl requested a review from avishniakov July 23, 2024 21:11
Copy link

dagshub bot commented Jul 23, 2024

torch>=2.2.0
sentencepiece
huggingface_hub
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This handles gated models

@@ -121,7 +134,7 @@ def finetune(
output_dir=output_dir,
warmup_steps=warmup_steps,
per_device_train_batch_size=per_device_train_batch_size,
gradient_checkpointing=True,
gradient_checkpointing=False,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows accelerated configs to work again

@strickvl strickvl requested review from safoinme and removed request for avishniakov July 24, 2024 08:25
@strickvl strickvl merged commit bdee3c1 into main Jul 24, 2024
3 checks passed
@strickvl strickvl deleted the feature/add-llama-3-1 branch July 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants