Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define valid sentence endings more strictly #3

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

gremid
Copy link
Member

@gremid gremid commented Dec 17, 2024

Also sentences that end with a punctuation token which could occur in the middle of a sentence, are penalized

@gremid gremid requested a review from Natalie-T-E December 17, 2024 18:49
@gremid gremid self-assigned this Dec 17, 2024
tests/test_gdex.py Outdated Show resolved Hide resolved
tests/test_gdex.py Show resolved Hide resolved
@gremid gremid force-pushed the bugfix/sentence-endings branch from 6c83232 to 04e128a Compare December 19, 2024 18:58
@gremid gremid merged commit 04e128a into main Dec 19, 2024
4 checks passed
@gremid gremid deleted the bugfix/sentence-endings branch December 19, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants