Arduino.h: Add digitalPinToInterrupt #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Ayush1325
commented
Sep 2, 2024
Ayush1325
commented
- Return the same number as long as not more than number of digital pins.
- This does not seem to be present in ArduinoCoreAPI but defined for all Arduino boards (and microblocks has started using it).
- Also present in arduino docs 1
Ayush1325
force-pushed
the
digitalPinToInterrupt
branch
2 times, most recently
from
dd45536 to
0e52b77
Compare
DhruvaG2000
requested changes
Sep 4, 2024
Ayush1325
force-pushed
the
digitalPinToInterrupt
branch
from
0e52b77 to
098ad74
Compare
|
I tried putting it in the anonymous namespace, but then I got undefined reference errors. So not sure if Note: I am not a C++ dev and have never used namespaces anything newer than C++98. So my understanding here is rather limited. |
Ayush1325
force-pushed
the
digitalPinToInterrupt
branch
from
098ad74 to
75846ac
Compare
- This does not seem to be present in ArduinoCoreAPI but defined for all Arduino boards (and microblocks has started using it). - Also present in arduino docs. Signed-off-by: Ayush Singh <[email protected]>
Ayush1325
force-pushed
the
digitalPinToInterrupt
branch
from
75846ac to
b0e70a0
Compare
DhruvaG2000
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.