Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32cube: Modify SAI_TypeDef U585 #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chrisschir
Copy link

Changed SAI_TypeDef of U585 to consist
of two SAI_Block_TypeDef

Signed-off-by: Christopher Schirk [email protected]

Changed SAI_TypeDef of U585 to consist
of two SAI_Block_TypeDef

Signed-off-by: Christopher Schirk <[email protected]>
@erwango
Copy link
Member

erwango commented Jan 6, 2025

@chrisschir Thanks for this contribution, but this repo aims at being a "fork" of STM32Cube packages so we don't modify HAL if we know modification won't be integrated in Cube package. Though we can merge fixes waiting for official Cube package delivery.

The change you proposed doesn't seem to fall in the bug fix category and the impact of the change may be larger than intended.
Would you min explaining what was the issue that lead you to this change and why it can only be fixed this way?

In any case, I'd suggest to open the issue in https://github.com/STMicroelectronics/STM32CubeU5 and explain why it is required.

@chrisschir
Copy link
Author

@erwango I created an issue: STMicroelectronics/STM32CubeU5#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants